Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serialization of status list (#1423) #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Oran-Dan
Copy link

@Oran-Dan Oran-Dan commented Nov 18, 2024

  • Add serialization for usize as string in StatusList2021Entry

  • Add test for statusListIndex serialization in StatusList2021Entry

  • chore: downgrade rust version for wasm crate

  • chore: fmt

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

Be sure to reference any related issues by adding fixes issue #.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

* Add serialization for usize as string in StatusList2021Entry

* Add test for statusListIndex serialization in StatusList2021Entry

* chore: downgrade rust version for wasm crate

* chore: fmt
@Oran-Dan Oran-Dan changed the base branch from main to fix/compile-fixes November 19, 2024 14:52
@Oran-Dan Oran-Dan changed the base branch from fix/compile-fixes to main November 19, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants